fix: omit structured_content when None instead of serializing as null#6499
Merged
angiejones merged 1 commit intomainfrom Jan 17, 2026
Merged
fix: omit structured_content when None instead of serializing as null#6499angiejones merged 1 commit intomainfrom
angiejones merged 1 commit intomainfrom
Conversation
The MCP spec defines structuredContent as optional (field may be absent), not nullable. Zod's .optional() schema accepts undefined but rejects null. Without skip_serializing_if, serde serializes Option::None as null, causing Zod validation errors in MCP Apps when calling tools. Fixes #6454
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a serialization issue where structured_content in MCP tool responses was being serialized as null instead of being omitted when absent, causing Zod validation errors in MCP Apps.
Changes:
- Added
#[serde(skip_serializing_if = "Option::is_none")]to thestructured_contentfield inCallToolResponseto align with the MCP spec
The-Best-Codes
approved these changes
Jan 14, 2026
angiejones
approved these changes
Jan 17, 2026
fbalicchia
pushed a commit
to fbalicchia/goose
that referenced
this pull request
Jan 23, 2026
…block#6499) Signed-off-by: fbalicchia <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP spec defines
structuredContentas optional (field may be absent), not nullable:Without
skip_serializing_if, serde serializesOption::Noneasnullin JSON, but Zod's.optional()schema acceptsundefined(field absent) and rejectsnull.This was causing Zod validation errors in MCP Apps when calling tools that don't return structured content.
Changes
Added
#[serde(skip_serializing_if = "Option::is_none")]tostructured_contentfield inCallToolResponseso the field is omitted from JSON whenNone, aligning with the MCP spec.Related
Fixes #6454
See: #6454 (comment)