fix(codex): correct codex reasoning effort conversion#6523
Merged
DOsinga merged 1 commit intoblock:mainfrom Jan 28, 2026
Merged
fix(codex): correct codex reasoning effort conversion#6523DOsinga merged 1 commit intoblock:mainfrom
DOsinga merged 1 commit intoblock:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the codex reasoning effort configuration parsing where the value was incorrectly converted using the Display trait instead of extracting the inner value, causing validation to fail and trigger warnings.
Changes:
- Changed
.map(|r| r.to_string())to.map(String::from)for proper extraction of the inner String value from theCodexReasoningEffortwrapper type
Use inner String conversion so CODEX_REASONING_EFFORT parses correctly and doesn’t warn/fallback. Signed-off-by: Federico G. Schwindt <[email protected]>
fgsch
force-pushed
the
fgsch/push-myvmtlqpzszu
branch
from
5cef842 to
3b4524e
Compare
DOsinga
approved these changes
Jan 28, 2026
Collaborator
|
thank you and sorry for the delay! |
eliasposen
pushed a commit
to eliasposen/goose
that referenced
this pull request
Jan 28, 2026
Signed-off-by: Federico G. Schwindt <[email protected]> Signed-off-by: Elias Posen <[email protected]>
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use inner String conversion so CODEX_REASONING_EFFORT parses correctly and doesn’t warn/fallback.
Type of Change
AI Assistance
Testing
Manual testing
Related Issues
Relates to #6515
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: