update doc to remind contributors to activate hermit and document minimal npm and node version by lifeizhou-ap · Pull Request #6727 · block/goose

lifeizhou-ap · 2026-01-27T01:14:51Z

Summary

Why
Contributor used different npm versions (V11.3.0) and generated package-lock.json differently (e.g., peer: true fields), causing lockfile drift across contributors.

What

Added minimal node and npm version in package.json. If the user's version does not match, they will see warning message when run npm install
Updated contribution guide regarding hermit activation

Type of Change

AI Assistance

This PR was created or reviewed with AI assistance

Testing

CI

Copilot

Pull request overview

This PR tightens Node.js and npm version enforcement for the desktop UI to reduce package-lock.json drift between contributors. The changes add an npm engine constraint and enable strict engine checking in the desktop app’s npm configuration.

Changes:

Declare npm: "^11.3.0" alongside the existing node: "^24.0.0" in ui/desktop/package.json.
Mirror the engine constraints in the root package entry of ui/desktop/package-lock.json.
Enable engine-strict=true in ui/desktop/.npmrc so npm enforces the declared engines at install time.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
ui/desktop/package.json	Adds an npm engine constraint to keep contributors on a minimum npm version aligned with the Node 24 requirement.
ui/desktop/package-lock.json	Updates the lockfile’s root package metadata to include the new npm engine constraint, keeping it consistent with `package.json`.
ui/desktop/.npmrc	Enables strict engine enforcement so installs fail when Node/npm don’t meet the declared minimum versions.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

Copilot · 2026-01-27T01:17:13Z

ui/desktop/.npmrc

@@ -1 +1,2 @@
 registry=https://registry.npmjs.org/
+engine-strict=true


With engine-strict=true and "node": "^24.0.0" in ui/desktop/package.json, any npm install in this package (including the Bundle Desktop (Windows) workflow which currently uses Node 22 via actions/setup-node) will now fail the engine check; please either align the CI/workflow Node version with ^24.0.0 or relax/remove engine-strict so existing release workflows continue to run.

@lifeizhou-ap is this valid?

yes, what copilot said is valid. Now I decided to remove it and not to enforce the check. I've also update the doc so that it is clear for users about the prerequisite of hermit activation

Copilot

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

Comments suppressed due to low confidence (1)

.github/workflows/bundle-desktop-windows.yml:71

You've updated the Node version used by this workflow to 24, but the npm cache key and restore-keys still embed the old "node22" label, which can be misleading when debugging or rotating caches; consider updating the cache key prefix to match the current Node major version.

          node-version: 24

      - name: Cache node_modules
        uses: actions/cache@2f8e54208210a422b2efd51efaa6bd6d7ca8920f # pin@v3
        with:
          path: |
            node_modules
            ui/desktop/node_modules
            .hermit/node/cache
          key: windows-npm-cache-v1-${{ runner.os }}-node22-${{ hashFiles('**/package-lock.json') }}
          restore-keys: |
            windows-npm-cache-v1-${{ runner.os }}-node22-

Copilot · 2026-01-29T04:02:54Z

ui/desktop/package.json

  "engines": {
-    "node": "^24.0.0"
+    "node": ">=24.10.0",
+    "npm": ">=11.6.1"


The npm and node engine constraints here don't match the values described in the PR summary (which mentions npm "^11.3.0" and node "^24.0.0"), so it's unclear which versions are intended to be the minimum enforced ones; please either align these "engines" values with the description or update the PR description to reflect the chosen constraints.

Copilot

Pull request overview

Copilot reviewed 2 out of 4 changed files in this pull request and generated no new comments.

Files not reviewed (1)

ui/desktop/package-lock.json: Language not supported

Abhijay007

LGTM

* 'main' of github.com:block/goose: (62 commits) Swap canonical model from openrouter to models.dev (#6625) Hook thinking status (#6815) Fetch new skills hourly (#6814) copilot instructions: Update "No prerelease docs" instruction (#6795) refactor: centralize audience filtering before providers receive messages (#6728) update doc to remind contributors to activate hermit and document minimal npm and node version (#6727) nit: don't spit out compaction when in term mode as it fills up the screen (#6799) fix: correct tool support detection in Tetrate provider model fetching (#6808) Session manager fixes (#6809) fix(desktop): handle quoted paths with spaces in extension commands (#6430) fix: we can default gooseignore without writing it out (#6802) fix broken link (#6810) docs: add Beads MCP extension tutorial (#6792) feat(goose): add support for AWS_BEARER_TOKEN_BEDROCK environment variable (#6739) [docs] Add OSS Skills Marketplace (#6752) feat: make skills available in codemode (#6763) Fix: Recipe Extensions Not Loading in Desktop (#6777) Different approach to determining final confidence level of prompt injection evaluation outcomes (#6729) fix: read_resource_tool deadlock causing test_compaction to hang (#6737) Upgrade error handling (#6747) ...

…sion-session * 'main' of github.com:block/goose: (78 commits) copilot instructions: Update "No prerelease docs" instruction (#6795) refactor: centralize audience filtering before providers receive messages (#6728) update doc to remind contributors to activate hermit and document minimal npm and node version (#6727) nit: don't spit out compaction when in term mode as it fills up the screen (#6799) fix: correct tool support detection in Tetrate provider model fetching (#6808) Session manager fixes (#6809) fix(desktop): handle quoted paths with spaces in extension commands (#6430) fix: we can default gooseignore without writing it out (#6802) fix broken link (#6810) docs: add Beads MCP extension tutorial (#6792) feat(goose): add support for AWS_BEARER_TOKEN_BEDROCK environment variable (#6739) [docs] Add OSS Skills Marketplace (#6752) feat: make skills available in codemode (#6763) Fix: Recipe Extensions Not Loading in Desktop (#6777) Different approach to determining final confidence level of prompt injection evaluation outcomes (#6729) fix: read_resource_tool deadlock causing test_compaction to hang (#6737) Upgrade error handling (#6747) Fix/filter audience 6703 local (#6773) chore: re-sync package-lock.json (#6783) upgrade electron to 39.3.0 (#6779) ...

* main: docs: usage data collection (#6822) feat: platform extension migrator + code mode rename (#6611) feat: CLI flag to skip loading profile extensions (#6780) Swap canonical model from openrouter to models.dev (#6625) Hook thinking status (#6815) Fetch new skills hourly (#6814) copilot instructions: Update "No prerelease docs" instruction (#6795) refactor: centralize audience filtering before providers receive messages (#6728) update doc to remind contributors to activate hermit and document minimal npm and node version (#6727) nit: don't spit out compaction when in term mode as it fills up the screen (#6799) fix: correct tool support detection in Tetrate provider model fetching (#6808) Session manager fixes (#6809) fix(desktop): handle quoted paths with spaces in extension commands (#6430) fix: we can default gooseignore without writing it out (#6802) fix broken link (#6810) docs: add Beads MCP extension tutorial (#6792) feat(goose): add support for AWS_BEARER_TOKEN_BEDROCK environment variable (#6739)

…imal npm and node version (block#6727)

enforce minimal node and npm version check

ec6c605

Copilot AI review requested due to automatic review settings January 27, 2026 01:14

Copilot started reviewing on behalf of lifeizhou-ap January 27, 2026 01:16 View session

lifeizhou-ap mentioned this pull request Jan 27, 2026

Fix: ElevenLabs API Key Not Persisting #6557

Merged

2 tasks

Copilot AI reviewed Jan 27, 2026

View reviewed changes

lifeizhou-ap added 2 commits January 27, 2026 12:47

upgrade node to v24

3db068f

updated the doc

3970381

Copilot AI review requested due to automatic review settings January 29, 2026 04:00

Copilot started reviewing on behalf of lifeizhou-ap January 29, 2026 04:01 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

lifeizhou-ap added 2 commits January 29, 2026 15:13

removed enforce engine check and enhance doc

84425c5

update package lock json

670718b

Copilot AI review requested due to automatic review settings January 29, 2026 04:26

Copilot started reviewing on behalf of lifeizhou-ap January 29, 2026 04:26 View session

lifeizhou-ap changed the title ~~enforce minimal node and npm version check~~ update doc to remind contributors to activate hermit and document minimal npm and node version Jan 29, 2026

Copilot AI reviewed Jan 29, 2026

View reviewed changes

lifeizhou-ap requested a review from Abhijay007 January 29, 2026 04:33

Abhijay007 approved these changes Jan 29, 2026

View reviewed changes

DOsinga merged commit e89b7d8 into main Jan 29, 2026
24 checks passed

DOsinga deleted the lifei/enforce-npm-version branch January 29, 2026 16:32

github-actions bot mentioned this pull request Feb 3, 2026

chore(release): release version 1.23.0 (minor) #6906

Merged

Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026

update doc to remind contributors to activate hermit and document min…

eb4ac84

…imal npm and node version (block#6727)

Tyler-Hardin pushed a commit to Tyler-Hardin/goose that referenced this pull request Feb 11, 2026

update doc to remind contributors to activate hermit and document min…

b2f85aa

…imal npm and node version (block#6727)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update doc to remind contributors to activate hermit and document minimal npm and node version#6727

update doc to remind contributors to activate hermit and document minimal npm and node version#6727
DOsinga merged 5 commits intomainfrom
lifei/enforce-npm-version

lifeizhou-ap commented Jan 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 27, 2026

Uh oh!

zanesq Jan 27, 2026

Uh oh!

lifeizhou-ap Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Abhijay007 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -1 +1,2 @@
		registry=https://registry.npmjs.org/
		engine-strict=true No newline at end of file

Conversation

lifeizhou-ap commented Jan 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

AI Assistance

Testing

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

zanesq Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

lifeizhou-ap Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 29, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Abhijay007 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lifeizhou-ap commented Jan 27, 2026 •

edited

Loading