Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the canonical model builder/checker script to reduce warnings and clean up repetitive logic while keeping behavior largely the same.
Changes:
- Extracted helpers for data-path construction, models.dev fetch, and per-model processing.
- Reduced repeated string allocations/cloning in mapping-report generation/comparison by using
&str-backed maps/sets. - Centralized repeated output formatting into separator constants.
Comment on lines
+327
to
+330
| response | ||
| .json() | ||
| .await | ||
| .context("Failed to parse models.dev response")?; | ||
| .context("Failed to parse models.dev response") |
There was a problem hiding this comment.
fetch_models_dev parses the response body as JSON without first checking for non-2xx HTTP status codes, which can hide the real failure cause (e.g., 404/500) behind a JSON parse error. Call error_for_status() (or explicitly check status().is_success()) on the response before attempting .json() and include the status in the error context.
katzdave
approved these changes
Feb 2, 2026
katzdave
added a commit
that referenced
this pull request
Feb 3, 2026
…ntext * 'main' of github.com:block/goose: refactor(providers): extract ProviderDef trait and OpenAiCompatibleProvider (#6832) feat: ask ai discord bot (#6842) chore(maintenance): make GitHub repo configurable for auto-updater and publisher (#6828) fix: make apps work in built copies of goose (#6901) Remove dependency on goose-mcp from goose crate (#6637) Clean up build canonical warnings (#6880) Sync desktop_prompt with UI (#6898)
stebbins
pushed a commit
to stebbins/goose
that referenced
this pull request
Feb 4, 2026
Co-authored-by: Douwe Osinga <[email protected]> Signed-off-by: Harrison <[email protected]>
kuccello
pushed a commit
to kuccello/goose
that referenced
this pull request
Feb 7, 2026
Co-authored-by: Douwe Osinga <[email protected]>
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Co-authored-by: Douwe Osinga <[email protected]>
Tyler-Hardin
pushed a commit
to Tyler-Hardin/goose
that referenced
this pull request
Feb 11, 2026
Co-authored-by: Douwe Osinga <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove a warning for too many lines. also other clean up.