Fix greenlet integration with greenlet 3.4.0#908
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
==========================================
- Coverage 92.49% 92.38% -0.12%
==========================================
Files 99 99
Lines 11746 11785 +39
Branches 426 429 +3
==========================================
+ Hits 10865 10888 +23
- Misses 881 897 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Specifically, the full failure mode here is:
The |
lkollar
left a comment
There was a problem hiding this comment.
Would it be worth mentioning that in the news fragment that this drops greenlet support before 1.0? LGTM otherwise.
Our attempts to handle ancient versions of greenlet are causing us to try to import the `settrace` function from `greenlet` rather than from `greenlet._greenlet`, which is failing because we're trying to import it before greenlet's own `__init__.py` has imported it. Drop support for greenlet versions older than 1.0, which is more than 5 years out of date at this point, to fix this issue. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
cab63e9 to
f739785
Compare
Good point, done. |
Our attempts to handle ancient versions of greenlet are causing us to try to import the
settracefunction fromgreenletrather than fromgreenlet._greenlet, which is failing because we're trying to import it before greenlet's own__init__.pyhas imported it.Drop support for greenlet versions older than 1.0, which is more than 5 years out of date at this point, to fix this issue.