Restrict the units that can be added to PlainYearMonth#671
Merged
nekevss merged 2 commits intoboa-dev:mainfrom Feb 3, 2026
Merged
Restrict the units that can be added to PlainYearMonth#671nekevss merged 2 commits intoboa-dev:mainfrom
nekevss merged 2 commits intoboa-dev:mainfrom
Conversation
Manishearth
force-pushed
the
pym-restrict-units
branch
from
8fb96ef to
2bdca83
Compare
Contributor
Author
|
Additional V8 change for order-of-operations reasons: https://chromium-review.googlesource.com/c/v8/v8/+/7527580 Edit: they changed the spec, this is not necessary. |
brave-builds
pushed a commit
to brave/chromium
that referenced
this pull request
Jan 28, 2026
Uplift of boa-dev/temporal#671 New spec change, with incoming tests. Change-Id: Ia236b9e72b2147cd7b21d2dd5fb610c8c7c1891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526972 Auto-Submit: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576136}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 28, 2026
Uplift of boa-dev/temporal#671 New spec change, with incoming tests. Change-Id: Ia236b9e72b2147cd7b21d2dd5fb610c8c7c1891d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7526972 Auto-Submit: Manish Goregaokar <manishearth@google.com> Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/main@{#1576136} NOKEYCHECK=True GitOrigin-RevId: 84b16b6c427deef36aea36ca8b5799923cd4fe33
Contributor
Author
|
test262 commit 1115529eaccb7411b11834efbd0551dbd04f42cd passes with https://chromium-review.googlesource.com/c/v8/v8/+/7528669 with the added SKIPs removed. This PR will cause more failures in the interim until those tests are also updated, for temporal_rs clients wishing to pull this in. |
nekevss
approved these changes
Feb 3, 2026
Member
nekevss
left a comment
nekevss
left a comment
There was a problem hiding this comment.
Looks good!
Apologies for the late review 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the spec text from tc39/proposal-temporal#3253
That change hasn't landed yet, but there are test262 tests relying on this (tc39/test262#4883)