Fix drop_duplicates() for non-trivial Indexes#925
Merged
Conversation
10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #925 +/- ##
==========================================
+ Coverage 66.68% 68.79% +2.10%
==========================================
Files 186 195 +9
Lines 66795 67566 +771
Branches 9507 9595 +88
==========================================
+ Hits 44543 46481 +1938
+ Misses 19572 18253 -1319
- Partials 2680 2832 +152 |
Collaborator
Author
|
The CI failure seems flakiness (coverage file not found.) |
scott-routledge2
approved these changes
Nov 12, 2025
scott-routledge2
left a comment
scott-routledge2
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ehsantn
| } | ||
| ) | ||
| df.loc[99, "B"] = np.nan | ||
| # TODO: Add groupby dropna flag to DuckDB's aggregate node so the flag is |
Contributor
There was a problem hiding this comment.
Is there an issue for this yet?
Collaborator
Author
There was a problem hiding this comment.
Opened an issue and added the issue number.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes included in this PR
Also fixes dropna flag in drop_duplicates' groupby call. Fixes semi join test of Narwhals.
Testing strategy
Added unit test.
User facing changes
Bug fix.
Checklist
[run CI]in your commit message.