Skip to content

fix(states): add endpoints required for location state#120

Open
pitust wants to merge 1 commit intobogosj:mainfrom
pitust:main
Open

fix(states): add endpoints required for location state#120
pitust wants to merge 1 commit intobogosj:mainfrom
pitust:main

Conversation

@pitust
Copy link

@pitust pitust commented Dec 1, 2023

The tesla API updated, requiring the endpoints parameter in vehicle_data to return some types of information (like vehicle location). Add this parameter to the request so that the existing API continues to function.

@bogosj bogosj requested a review from andig December 1, 2023 21:45
@andig
Copy link
Collaborator

andig commented Dec 2, 2023

I don‘t know if thats required, but may be (Owners api). In Go, I‘d suggest to let the url Library do the escaping instead of writing escaped strings directly as it is error prone.

The tesla API updated, requiring the endpoints parameter in vehicle_data to
return some types of information (like vehicle location). Add this parameter to
the request so that the existing API continues to function.
@pitust
Copy link
Author

pitust commented Dec 2, 2023

I don‘t know if thats required, but may be (Owners api).

It is required to get the location information (latitude, longitude) via the API.

In Go, I‘d suggest to let the url Library do the escaping instead of writing escaped strings directly as it is error prone.

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments