Conversation
- Only allow session deletion if MaxAge is negative, not zero Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where session cookies with MaxAge = 0 were incorrectly being deleted instead of being treated as browser session cookies. The fix changes the condition from <= 0 to < 0, ensuring only sessions explicitly marked for deletion (MaxAge < 0) are removed.
Changes:
- Updated the condition in the
Savemethod to only delete sessions whenMaxAge < 0instead ofMaxAge <= 0
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add regression test to verify session cookies (MaxAge=0) are created without Max-Age attribute and saved to Redis with the default TTL - Ensure session retrieval from Redis preserves values for session cookies - Confirm that setting MaxAge to -1 deletes the session from Redis Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #53
fixed #55