If form was not found, try again using a looser CSS selector#24
Merged
boldsidney merged 1 commit intoboldcommerce:masterfrom Jul 9, 2018
peterjaap:cleancheckout-compat
Merged
If form was not found, try again using a looser CSS selector#24boldsidney merged 1 commit intoboldcommerce:masterfrom peterjaap:cleancheckout-compat
boldsidney merged 1 commit intoboldcommerce:masterfrom
peterjaap:cleancheckout-compat
Conversation
Contributor
|
hi @peterjaap , I had a quick look on an install with
But i didnt realy discover any incompatibilities with the clean checkout extension, when using the old form selector. The comment was properly passed to the order. Do i need certain settings to reproduce the issue that this pull request addresses? |
Contributor
Author
|
@boldsidney we show the order comment field below the payment methods, instead of per payment method. I just can't remember which settings that was.. |
Contributor
|
hi @peterjaap , I haven't found this particular setting you speak of, but seeing as this is an useful change for those that have moved the comment field, I'll merge it anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compatibility for Rubic_CleanCheckout. The order comment wasn't passed because the form wasn't found in the checkout.