Skip to content

Make Embed fields accessible #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobdenotter merged 3 commits into from
Feb 25, 2021
Merged

Make Embed fields accessible #2430

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c8d71d
Make Embed fields accessible
I-Valchev Feb 25, 2021
d259eba
Clean up messages from master
I-Valchev Feb 25, 2021
86a3041
Update messages.en.xlf
I-Valchev Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions assets/js/app/editor/Components/Embed.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
class="form-control"
:name="name + '[url]'"
:placeholder="labels.placeholder_content_url"
:title="labels.placeholder_content_url"
type="url"
:required="required"
:readonly="readonly"
Expand All @@ -23,12 +24,18 @@
class="btn btn-tertiary refresh"
type="button"
:disabled="loading"
:aria-label="labels.refresh"
@click="updateEmbed"
>
<i :class="(loading ? 'fa-spin' : '') + ' fas fa-sync mr-0'"></i>
</button>

<button class="btn btn-hidden-danger remove" type="button" @click="clearEmbed">
<button
class="btn btn-hidden-danger remove"
type="button"
:aria-label="labels.delete"
@click="clearEmbed"
>
<i class="fas fa-trash mr-0"></i>
</button>
</span>
Expand All @@ -42,6 +49,7 @@
type="number"
:value="widthData"
:readonly="readonly"
:title="labels.field_width"
/>
×
<label for="embed-height-size" class="sr-only">{{ labels.label_height }}</label>
Expand All @@ -51,6 +59,7 @@
type="number"
:value="heightData"
:readonly="readonly"
:title="labels.field_height"
/>
<label>{{ labels.label_pixel }}</label>
</div>
Expand All @@ -60,15 +69,15 @@
class="form-control title"
:name="name + '[title]'"
readonly=""
title="Title"
:title="labels.field_title"
type="text"
:value="titleData"
/>
<input
class="form-control author_name"
:name="name + '[authorname]'"
readonly=""
title="Author"
:title="labels.field_author"
type="text"
:value="authornameData"
/>
Expand Down
6 changes: 6 additions & 0 deletions templates/_partials/fields/embed.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@
'label_matched_embed': 'editor_embed.label_matched_embed'|trans,
'label_preview': 'editor_embed.label_preview'|trans,
'label_size': 'editor_embed.label_size'|trans,
'delete': 'action.delete'|trans,
'refresh': 'action.refresh'|trans,
'field_width': 'field.width'|trans,
'field_height': 'field.height'|trans,
'field_title': 'field.title'|trans,
'field_author': 'field.author'|trans,
}|json_encode }}"
></editor-embed>
{% endblock %}
6 changes: 6 additions & 0 deletions translations/messages.en.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2595,5 +2595,11 @@
<target>filtered by</target>
</segment>
</unit>
<unit id="CvNi3GD" name="action.refresh">
<segment>
<source>action.refresh</source>
<target>Refresh</target>
</segment>
</unit>
</file>
</xliff>