Update Date.vue dateFormat to include seconds#3096
Merged
Conversation
…tabase original and edited version
Contributor
|
Hey! First of all nice fix! But I don't think it happens on the background only as the Cypress tests are failing. One way to fix this is by editing the failing tests over here: It should be fixed by just adding the seconds it should expect. If the tests work then we can merge it in 😄 |
Contributor
Author
|
Thanks @Joossensei for the tip on where to fix the tests. It looks like these tests do check a value in the dom that is not visible to the user, but as it is the actual value that should be posted it is important to fix them anyway -- I'll try to get that done this week. |
bobdenotter
changed the title
Date.vue dateFormat to include seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added seconds to dateFormat to fix issue with date-compare between database original and edited version, causing users that didn't have the right to change publication dates to be denied making edits.
This fixes #3082
Note, this is only for the
dateFormat, this is used 'behind the scenes' in this vue component and is used to post to the server, the actual format shown is specified inaltFormat.