cancelling the archive check doesnt kill the underlying borg command

[sandrotosi]

Describe the bug
cancelling the archive check doesnt kill the underlying borg command

To Reproduce
Steps to reproduce the behavior:

1. have a backup enabled with the option "Validate repository data every ..." enabled
2. when the check step is running, click cancel at the bottom right
3. the action is marked as cancelled but the underlying borg command is not killed and keeps running.

Environment (please complete the following information):

• OS: Debian unstable
• Vorta version: 0.7.5
• Installed from: debian package

[m3nu]

Wow. We are already very aggressive in killing that process. Basically if it doesn't react to SIGINT within X seconds, the whole process group is terminated. So a bit surprising.

[m3nu]

Is this a remote or local repo?

[sandrotosi]

this is a "local" repo, as in it's an NFS share mounted on a local directory

[m3nu]

Tried to reproduce this on a VMWare-mounted share, but failed. Maybe it needs a slow network share to reproduce.

[sandrotosi]

i wouldnt call this a slow network share: it's a 1gbps ethernet cabled connection from my laptop, to a switch, to a nas.

FTR it happened again a couple of days ago (that's the weekly check running not the backup): i decided to cancel the check but the process didnt die, so i had to kill it by hand

[m3nu]

I also tried cancelling, when running the borg check command to a remote repo over the internet.

Will cancelling also fail for you for remote repos or just network shares?

[m3nu]

Here the "kill code", if you want to play with it: https://github.com/borgbase/vorta/blob/master/src/vorta/borg/borg_thread.py#L277

[sandrotosi]

I also tried cancelling, when running the borg check command to a remote repo over the internet.

ok this is interesting: did you go to the "Archives" tab and press "Check" at the bottom of it? i was able to cancel the check by following that sequence of steps.

The situation for which i reported this bug is slightly different: i cannot kill the check when executed automatically after a backup, as scheduled by enabling "Validate repository data ever X weeks" in the "Schedule" tab.

[m3nu]

Oh. I started it manually from Archives.

The scheduled check will use the same Borg thread, but there could be small differences. So let me try that too.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.