feat: add settings for files list views#1621
Merged
Merged
Conversation
real-yfprojects
previously approved these changes
Mar 11, 2023
Collaborator
real-yfprojects
left a comment
real-yfprojects
left a comment
There was a problem hiding this comment.
Works as expected! Thank you.
m3nu
approved these changes
Apr 5, 2023
diivi
added a commit
to diivi/vorta
that referenced
this pull request
Apr 11, 2023
* feat: add a setting for files list views * separate logic from data class * make mode optional * rename display mode methods * refactor * move code above connect signals comment * reorder code --------- Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com>
DaffyTheDuck
pushed a commit
to DaffyTheDuck/vorta
that referenced
this pull request
Jun 14, 2023
* feat: add a setting for files list views * separate logic from data class * make mode optional * rename display mode methods * refactor * move code above connect signals comment * reorder code --------- Co-authored-by: yfprojects <62463991+real-yfprojects@users.noreply.github.com> Co-authored-by: Manu <3916435+m3nu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added two settings to remember user's preferred files list view in the diff and extract dialogs
extract_files_display_modediff_files_display_modefixes #1516
Motivation and Context
Improves UX
How Has This Been Tested?
Tested by changing the views and reopening vorta.
Types of changes
Checklist:
I have to update the tests, then I'll make this ready for review.
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.