feat: add profile name to log messages#1637
Conversation
|
This would also be useful for the other messages like |
|
I did this for |
Yes, since currently one has no way to tell which backup has finished. |
So why not do this just for the Backup Finished message instead of every progress event? |
Doesn't it also apply to other progress messages? None of them state the profile they are originating from. |
|
Hey, I need some help understanding how I can get the profile name in the various jobs in vorta. For example the create job: def process_result(self, result):Should I access def started_event(self):How do I get the profile name to display in the progress event emitted by these functions? |
|
This could be cleaner and better but you can always access the profile from a BorgJob with self.params['profile_id'] |
|
I think you have to resolve the merge conflicts before the tests are run. |
…b.com/diivi/vorta into feat/add-profile-info-to-log-messages
real-yfprojects
left a comment
There was a problem hiding this comment.
I don't know a better way to use the same message template over and over again with a qt signal -- besides maybe writing a function.
* feat: add profile name to log messages * update tests * add profile name to all occurences of backup progress event emit * update tests * merge with logs link code --------- Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
In a similar fashion like borgbase#1637 the commit adds the profile name to the error notification. * src/vorta/scheduler.py
* feat: add profile name to log messages * update tests * add profile name to all occurences of backup progress event emit * update tests * merge with logs link code --------- Co-authored-by: Hofer-Julian <30049909+Hofer-Julian@users.noreply.github.com>
In a similar fashion like #1637 the commit adds the profile name to the error notification. * src/vorta/scheduler.py Co-authored-by: herrwusel <herrwusel@noreply.github.com>
Description
Append profile name to every log message
Related Issue
#1379
Motivation and Context
Helps the user know which profile the log is coming from.
How Has This Been Tested?
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.