Allow many arguments to be passed to Socket.emit()#78
Open
saveriodesign wants to merge 2 commits intobougarfaoui:masterfrom
saveriodesign:master
Open
Allow many arguments to be passed to Socket.emit()#78saveriodesign wants to merge 2 commits intobougarfaoui:masterfrom saveriodesign:master
saveriodesign wants to merge 2 commits intobougarfaoui:masterfrom
saveriodesign:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue #77
To get this to work in a deployment I had to change the compiled NPM version, as you've changed the structure a fair bit between 0.1.5 and 0.2.4. However the spirit of this change to the TS works and let's a client emit a multitude of arguments to a server, which is permitted by the underlying Socket.IO