Skip to content

Use default credential provider chain for AWS#51

Merged
jordanjennings merged 2 commits intoboxboat:developfrom
jordanjennings:aws-default-credential-chain
Mar 14, 2022
Merged

Use default credential provider chain for AWS#51
jordanjennings merged 2 commits intoboxboat:developfrom
jordanjennings:aws-default-credential-chain

Conversation

@jordanjennings
Copy link
Copy Markdown
Contributor

fixes #50

fixes boxboat#50

Signed-off-by: Jordan Jennings <jordan@boxboat.com>
@jordanjennings jordanjennings force-pushed the aws-default-credential-chain branch from e5c2cda to a6998e1 Compare March 11, 2022 17:01
Copy link
Copy Markdown
Contributor

@matthewdevenny matthewdevenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove the SessionProvider and corresponding methods

Signed-off-by: Jordan Jennings <jordan@boxboat.com>
@jordanjennings jordanjennings force-pushed the aws-default-credential-chain branch from 2a8b1a2 to 33a0033 Compare March 11, 2022 17:30
Copy link
Copy Markdown
Contributor

@matthewdevenny matthewdevenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jordanjennings jordanjennings merged commit 0a4257d into boxboat:develop Mar 14, 2022
@jordanjennings jordanjennings deleted the aws-default-credential-chain branch March 14, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AWS IAM Roles for Service Accounts

2 participants