[CLOSED] [Registry] Download counter broken?

[core-ai-bot]

Issue by uniphonic
Wednesday Dec 16, 2015 at 16:48 GMT
Originally opened as adobe/brackets#12010

---

The download counter for extensions now seem to be broken. This seems to have started happening at the exact same time as the fix was implemented for adobe/brackets#11932 .

If you have the "Extensions Rating" extension installed it shows download counts for all items, but all the download counts seem to have frozen since the 11932 fix was made (everything that was uploaded since then has remained locked at 0 for many days, though I know it's been downloaded many times). Maybe the fix that was made for issue 11932 broke something?

[core-ai-bot]

Comment by lkcampbell
Thursday Jan 28, 2016 at 17:58 GMT

---

Seems like we should at least prioritize and assign this problem. It's been down for quite a while now and, every day, we lose information about how people are using extensions.

[core-ai-bot]

Comment by uniphonic
Thursday Jan 28, 2016 at 21:19 GMT

---

I agree. :-)

[core-ai-bot]

Comment by kolipka
Monday Mar 14, 2016 at 14:55 GMT

---

Me too :)
I checked the brackets-registry and noticed that there is script:

downloadStats/downloadStatsUpdater.js

it will upload stats to registry server. It should be called propably in cron. Can someone check is it actually running?
The second thing is that in my case in lib/downloadData.js:36:

req.ip === "127.0.0.1"

is false because req.ip is '::ffff:127.0.0.1'. req.host is localhost, so this part is OK.

[core-ai-bot]

Comment by ingorichter
Monday Mar 21, 2016 at 17:57 GMT

---

The data for the downloads isn't lost. If the download data doesn't end up in the registry, then it looks like the downloadStats/downloadStatsUpdater.js is not running anymore. I set it up to run the script as a cron job.

@kolipka that is definitely an issue.

I don't have access to the registry server anymore. Somebody revoked my permissions and I can't have a look anymore. Perhaps@ryanstewart can help out to get access to the machine and inspect the current setup.

[core-ai-bot]

Comment by lkcampbell
Thursday Mar 31, 2016 at 18:49 GMT

---

@ingorichter okay, glad to hear the data isn't lost anyway :).

[core-ai-bot]

Comment by ficristo
Saturday Oct 01, 2016 at 09:38 GMT

---

@adobe/brackets-committers after 10 months someone at Adobe does care for this issue?
Can non adobe people have access to this machine?

[core-ai-bot]

Comment by uniphonic
Saturday Oct 01, 2016 at 20:26 GMT

---

@ryanstewart@madanbn@nethip Any chance one of you could take a look?

[core-ai-bot]

Comment by ingorichter
Sunday Oct 16, 2016 at 01:24 GMT

---

I don't have access to the machine anymore. Otherwise I could have a look

[core-ai-bot]

Comment by saurabh95
Sunday Jan 29, 2017 at 13:41 GMT

---

@ingorichter I have access to the machine and I searched for currently running cron jobs I was not able to find any, so I will try to add that cron job.
Just to be sure we need to run node downloadStats/downloadStatsUpdater.js, right?
Do you remember the time interval that was set for running the above cron job?

[core-ai-bot]

Comment by ingorichter
Tuesday Jan 31, 2017 at 07:42 GMT

---

@saurabh95 which user did you use to find the cron job? Did you run crontab -e? And that was empty?
Yes, that is the script. The script ran every 15 mins.
I tried to access the machine, but I didn't have the password to unlock the file that contained the certificate to establish a SSH connection.

[core-ai-bot]

Comment by saurabh95
Wednesday Feb 01, 2017 at 06:17 GMT

---

@ingorichter I was logged in as "brackets-team". I checked for cron job using crontab -l , it showed nothing and then I used crontab -e to check if it was edited or not, there were no edits in that.
Now I have updated the logs for the past 14 months and also started a cronjob for every day(will change it to every 15 minutes). You can check the registry.json file, it has updated download counts now :)

[core-ai-bot]

Comment by ingorichter
Wednesday Feb 01, 2017 at 22:43 GMT

---

@saurabh95 thanks for the update. Let me check the json file. :-)

[core-ai-bot]

Comment by swmitra
Friday Feb 03, 2017 at 05:41 GMT

---

Closing the issue now.