[CLOSED] CSS code hints in 'style' attribute value context

[core-ai-bot]

Issue by swmitra
Wednesday Apr 05, 2017 at 08:58 GMT
Originally opened as adobe/brackets#13270

---

This PR enables Brackets to provide CSS code hints property-value code hints while editing 'style' attribute value in 'html' mode. The implementation contains minor tweaks to the CSSUtils module to recognize this as 'css' context as CodeMirror doesn't understand the 'style' attribute value as 'css' context.

Adding@ingorichter@petetnt@zaggino and@ficristo for review, but others can also join 👍

---

swmitra included the following code: https://github.com/adobe/brackets/pull/13270/commits

[core-ai-bot]

Comment by ficristo
Thursday Apr 06, 2017 at 18:43 GMT

---

Sorry but I don't have enough interest in this feature to review it.
Maybe@humphd is interested?

[core-ai-bot]

Comment by swmitra
Friday Apr 07, 2017 at 05:20 GMT

---

@humphd Can you please have a look at this PR?

[core-ai-bot]

Comment by ingorichter
Sunday Apr 09, 2017 at 06:49 GMT

---

@swmitra it would be beneficial to have some unit tests for the new functionality. This is complex and might break accidentally.

[core-ai-bot]

Comment by swmitra
Sunday Apr 09, 2017 at 10:23 GMT

---

Sure@ingorichter. I will add some functional tests in this PR and ping you.

[core-ai-bot]

Comment by swmitra
Wednesday Apr 12, 2017 at 07:04 GMT

---

@ingorichter I have added some unit tests in my last commit.
@petetnt Fixed the multiline attribute value issue and corrected indentation.
Can you guys please review it once more? ☺️

[core-ai-bot]

Comment by ingorichter
Thursday Apr 13, 2017 at 21:25 GMT

---

I'm too late :-/