[CLOSED] Create index.html

[core-ai-bot]

Issue by FallingHeart
Thursday Jun 15, 2017 at 09:09 GMT
Originally opened as adobe/brackets#13446

---

zh-cn

---

FallingHeart included the following code: https://github.com/adobe/brackets/pull/13446/commits

[core-ai-bot]

Comment by FallingHeart
Thursday Jun 15, 2017 at 09:17 GMT

---

a Chinese translation

[core-ai-bot]

Comment by FallingHeart
Thursday Jun 15, 2017 at 11:20 GMT

---

@travis-ci

[core-ai-bot]

Comment by ficristo
Thursday Jun 15, 2017 at 19:19 GMT

---

FallingHeart has NOT submitted the contributor license agreement. See http://dev.brackets.io/brackets-contributor-license-agreement.html.

[core-ai-bot]

Comment by FallingHeart
Friday Jun 16, 2017 at 03:17 GMT

---

i get a license@ficristo

[core-ai-bot]

Comment by ficristo
Saturday Jun 17, 2017 at 13:03 GMT

---

@FallingHeart do you know someone who could review this ?
I think you are missing an entry in src/nls/zh-cn/urls.js: something like: "GETTING_STARTED" : "zh-cn/Getting Started".
You could also translate the Getting Started words if you want (and the link should be reflected in the GETTING_STARTED above)

[core-ai-bot]

Comment by FallingHeart
Sunday Jun 18, 2017 at 09:55 GMT

---

i am really sorry because i am totally a freshman here
and due to my poor english
i can not really understand what you are talking about
what does it mean by a single PR
what does PR stand for

[core-ai-bot]

Comment by ficristo
Sunday Jun 18, 2017 at 16:14 GMT

---

PR stands for Pull Request, what you have here is a pull request. You can think it as a request to merge your code.
Based on the branch names (patch-1 and patch-2) it seems to me you have used GitHub interface to create these PR. If I remember correctly GitGub interface doesn't allow you to modify more than one file.
Ideally you should have used a local clone of Brackets to change both files and do a single PR with both files modified. But you should also know / learn git commands to do it.

PS: my english is not really good either, I hope to have been clearer.

[core-ai-bot]

Comment by ficristo
Tuesday Jun 20, 2017 at 17:52 GMT

---

Superceded by adobe/brackets#13473