[CLOSED] Implementation of Navigate Recent Projects

[core-ai-bot]

Issue by TomMalbran
Tuesday Jul 23, 2013 at 08:49 GMT
Originally opened as adobe/brackets#4546

---

As specified in the this Trello card, CTRL+ALT+R opens the recent project dropdown, up and down moves to the next and previous item and enter triggers a click event`on the currently selected item, which goes to the selected project or opens a new folder (if that item is selected).

---

TomMalbran included the following code: https://github.com/adobe/brackets/pull/4546/commits

[core-ai-bot]

Comment by JeffryBooher
Wednesday Jul 24, 2013 at 02:00 GMT

---

done with first pass on the review

[core-ai-bot]

Comment by adrocknaphobia
Monday Jul 29, 2013 at 22:55 GMT

---

@TomMalbran Thanks for taking this on! Once the menu is open (Ctrl+Alt+R), the menu should be closed when hitting ESC, ENTER or when losing focus (e.g. click outside the menu). Typically menus don't toggle (at least not on Windows), but as long as ESC/ENTER works, I'm OK if Ctrl+Alt+R toggles the menu close as well.

[core-ai-bot]

Comment by TomMalbran
Monday Jul 29, 2013 at 23:05 GMT

---

@adrocknaphobia Sure, using Esc to to close the menu sounds good. Enter already closes it, since it works as clicking on any menu item. There wasn't any mention of it in the trello card, but I figure that there should be a way to close it using keyboard events. Using Alt when a native menu is open on Windows closes it, and alt is the way to open them, so maybe we could also leave Ctrl+Alt+R to close the menu.

[core-ai-bot]

Comment by TomMalbran
Monday Jul 29, 2013 at 23:24 GMT

---

@adrocknaphobia One other thing. There is still no way to remove projects from the list using the keyboard (can only be done clicking on the "x" button). Should we implement it using the BackSpace/Delete keys?

[core-ai-bot]

Comment by JeffryBooher
Monday Aug 05, 2013 at 22:15 GMT

---

@adrocknaphobia that doesn't feel right to me. Can you point to another tool that does it like that? Visual Studio you can only close windows from the Windows... Dialog at the bottom of the Window menu. Then it's a dialog that you can use to manage your windows. I'm afraid that delete would be confused with deleting the file from disk or from your project. On the Mac, Cmd+W is the typical shortcut to close the currently open document which I believe is implemented and Alt+F4 on Windows is as well. If not, then I think we should just let them close only the currently open document with those shortcuts. That's my $.02

[core-ai-bot]

Comment by TomMalbran
Tuesday Aug 13, 2013 at 03:33 GMT

---

@JeffryBooher I guess you are right. Using delete to remove the files might not be the best way. Anyway I think we should make it possible to remove the projects from the list using the keyboard only.

My other idea would be to make sure that tabbing works. When the menu is open tabbing should stay within the panel and should reach the "x" links. I was thinking of making the list items tab-able, so that you can tab to a list item, which will select it and show the delete icon and then tab to the delete icon. The next tab will select the following item in the list, or the first if we reached the end.

[core-ai-bot]

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:20 GMT

---

@TomMalbran That needs a UX involvement so I wouldn't get to far down the road on that but it sounds about right. Delete I think is outside the scope of this issue so I will add it to the product backlog if it isn't already. I need to test the changes and finish the review for this pull request.

[core-ai-bot]

Comment by JeffryBooher
Sunday Aug 25, 2013 at 03:30 GMT

---

@TomMalbran I tried this from an open document (using the keyboard to invoke the menu) and keys other than the ones that are expressly handled by the menu are going to the editor which isn't good. I then managed to get into a state with multiple popups showing because code hints popped up.

This doesn't happen when using the mouse to invoke the menu because focus is shifted to the drop down so I think you just need to set the document's active element to the popup.

[core-ai-bot]

Comment by TomMalbran
Sunday Aug 25, 2013 at 06:24 GMT

---

@JeffryBooher I was able to fix the blur issue, was harder than expected since I couldn't focus almost any element, but bluing CodeMirror works. I added an extra bit to refocus CodeMirror if you close the menu using Escape, so you can open the menu, close it and keep coding. I also removed the toggle on Ctrl+Alt+R. Now it only opens the menu, and Esc closes it.

[core-ai-bot]

Comment by JeffryBooher
Thursday Aug 29, 2013 at 04:41 GMT

---

Nominating for Sprint 31

[core-ai-bot]

Comment by JeffryBooher
Tuesday Sep 03, 2013 at 20:54 GMT

---

@TomMalbran almost there... I think the navigation keys (Left/Right/Home/End/PgUp/PgDn) are still going to code mirror. I tried vairous other keys and it seems that blocking those keys is all that remains.

[core-ai-bot]

Comment by peterflynn
Tuesday Sep 03, 2013 at 22:16 GMT

---

Couple quick thoughts -- apologies if any of this already came up...

• I think to fix the focus issue it's simplest to just explicitly focus the popup (I think you can render any DOM node focusable by just adding a tabIndex, even a negative one), rather than leaving the focus on CodeMirror and trying to prevent any key events from reaching it. I think this also means you could just use a regular key listener instead of the global key-hook mechanism.
• In handleKeyEvent(), we should probably always focus the popup -- not just if an editor had focus. If focus was in a search field or something, we still don't want any key input to go into that text field...
• Does anything bad happen if cleanupDropdown() just always re-focuses the editor? That would clean up the code because you wouldn't need all the stuff that plumbs the key event over from PopUpManager (which I worry just invites misuse by future pieces of code).

[core-ai-bot]

Comment by TomMalbran
Tuesday Sep 03, 2013 at 23:42 GMT

---

@peterflynn Thanks.

• I forgot about tabindex, which made the list focusable and I was able to do it.
• Is there any advantage of using a regular key listener instead of the global key-hook mechanism? and which one is better to use?
• It looks like everything works fine by always refocusing the editor.

@JeffryBooher Those navigation keys where used on the body, but now with the focus fix, those keys shouldn't run on the sidebar.

[core-ai-bot]

Comment by JeffryBooher
Wednesday Sep 04, 2013 at 16:44 GMT

---

@TomMalbran the edit keys are fixed there is one comment on a recent change (unused var) that needs to be fixed.

[core-ai-bot]

Comment by peterflynn
Wednesday Sep 04, 2013 at 20:05 GMT

---

@TomMalbran About the global key hook... I think it's intended for use in cases where you're trying to override someone else's global capture handler. Since that's not needed here, and the focus location is better now, I think it's simplest to use a standard DOM listener (jQuery, really).

The existing code you have up here, using the global key hook, seems like it will still work though. So if you'd rather get this merged now and do the cleanup later, that seems ok too.