fix: fix various issues and bugs with dpp::emoji#775
Merged
braindigitalis merged 2 commits intobrainboxdotcc:devfrom Aug 16, 2023
Merged
fix: fix various issues and bugs with dpp::emoji#775braindigitalis merged 2 commits intobrainboxdotcc:devfrom
braindigitalis merged 2 commits intobrainboxdotcc:devfrom
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
1c4372c to
2b13d54
Compare
braindigitalis
requested changes
Aug 16, 2023
Commandserver
approved these changes
Aug 16, 2023
braindigitalis
approved these changes
Aug 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devbranch.This PR fixes various bugs involving dpp::emoji, including a double free after copying an emoji with image data, as well as dpp::base64_encode reading past the end of the data sent to it. It also modernizes (a little bit) dpp::emoji, and adds utility functions to get a mime type and file extension from a dpp::image_type or a dpp::sticker_format.