fix add-on export hanging forever on compile errors#1655
Conversation
|
|
bdbdb6d to
e94e31d
Compare
|
Related to #1640 |
|
Was taking a look at this, I think there's another issue I want to make sure if fixed first which is just the build seemingly failing due to a missing folder which should not be missing. |
Oh mb ill take a look at it, you have any idea what it is? i didn't commit some artifacts as i thought they were generated for linux |
I just retried both the web and the native build and did not run into any issues. |
|
oh wait i just realized i misread the comment |
Description
When the exporting hits a compile error, the dash worker throws an error in
dash.build(), but this error never gets posted. So the main thread just waits forever and the progress notification is also never cleared. (actual error is swallowed and i thinkdash.dispose()was never really called, so I moved it in a finally block)Motivation
#1652
Additional Context
none needed