Skip to content

fix add-on export hanging forever on compile errors#1655

Open
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN wants to merge 2 commits into
bridge-core:mainfrom
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN:fix/export-error-report-failure
Open

fix add-on export hanging forever on compile errors#1655
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN wants to merge 2 commits into
bridge-core:mainfrom
grMLEqomlkkU5Eeinz4brIrOVCUCkJuN:fix/export-error-report-failure

Conversation

@grMLEqomlkkU5Eeinz4brIrOVCUCkJuN

Copy link
Copy Markdown
Contributor

Description

When the exporting hits a compile error, the dash worker throws an error in dash.build(), but this error never gets posted. So the main thread just waits forever and the progress notification is also never cleared. (actual error is swallowed and i think dash.dispose() was never really called, so I moved it in a finally block)

Motivation

#1652

Additional Context

none needed

@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@outercloudstudio

Copy link
Copy Markdown
Member

Related to #1640

@outercloudstudio

Copy link
Copy Markdown
Member

Was taking a look at this, I think there's another issue I want to make sure if fixed first which is just the build seemingly failing due to a missing folder which should not be missing.

@grMLEqomlkkU5Eeinz4brIrOVCUCkJuN

Copy link
Copy Markdown
Contributor Author

Was taking a look at this, I think there's another issue I want to make sure if fixed first which is just the build seemingly failing due to a missing folder which should not be missing.

Oh mb ill take a look at it, you have any idea what it is? i didn't commit some artifacts as i thought they were generated for linux

@grMLEqomlkkU5Eeinz4brIrOVCUCkJuN

Copy link
Copy Markdown
Contributor Author

Was taking a look at this, I think there's another issue I want to make sure if fixed first which is just the build seemingly failing due to a missing folder which should not be missing.

I just retried both the web and the native build and did not run into any issues.

@grMLEqomlkkU5Eeinz4brIrOVCUCkJuN

Copy link
Copy Markdown
Contributor Author

oh wait i just realized i misread the comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants