Add optional SwiftAPI attestation provider #3824

theonlypal · 2025-12-29T02:17:19Z

Adds optional action-level attestation via SwiftAPI.

High-risk actions (click, input, navigate, evaluate) require Ed25519-signed approval before execution. Read-only actions pass through.

Usage:

from browser_use.swiftapi_integration import SwiftAPITools

tools = SwiftAPITools(swiftapi_key="swiftapi_live_...")

Extends existing Tools/Agent classes
No breaking changes
Fail-closed without key (optional enforcement)
NullAttestationProvider for dev/testing

Live demo: https://github.com/theonlypal/browser-use-swiftapi

Summary by cubic

Adds optional SwiftAPI attestation for browser actions. High-risk actions require Ed25519-signed approval; read-only actions bypass attestation.

New Features
- Adds SwiftAPITools and SwiftAPIAgent to verify actions before execution.
- Configurable via SwiftAPIConfig (env vars, verbose logging, revocation checks, optional fail_open).
- Includes NullAttestationProvider for dev/testing and fail-closed behavior without a key. No breaking changes.

^{Written for commit e28f00a. Summary will update automatically on new commits.}

CLAassistant · 2025-12-29T02:17:25Z

All committers have signed the CLA.

cubic-dev-ai

4 issues found across 5 files

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="browser_use/swiftapi_integration/attestation.py">

<violation number="1" location="browser_use/swiftapi_integration/attestation.py:189">
P2: Unlike `verify` and `check_revocation`, this method lacks error handling for httpx exceptions. Consider wrapping in try/except for consistency and to provide meaningful `AttestationError` messages.</violation>
</file>

<file name="browser_use/swiftapi_integration/agent.py">

<violation number="1" location="browser_use/swiftapi_integration/agent.py:102">
P2: Comment says &#39;Copy registry&#39; but code shares the reference. If `provided_tools.registry` is modified elsewhere, it will affect `swiftapi_tools`. Consider using `.model_copy()` or creating a new registry instance if independent copies are intended.</violation>
</file>

<file name="browser_use/swiftapi_integration/tools.py">

<violation number="1" location="browser_use/swiftapi_integration/tools.py:167">
P2: The `_attestation_cache` is initialized but never used. This suggests an incomplete caching implementation - attestation results are never cached, which could result in redundant attestation calls for repeated actions. Either implement the caching logic or remove this unused attribute.</violation>
</file>

<file name="browser_use/swiftapi_integration/__init__.py">

<violation number="1" location="browser_use/swiftapi_integration/__init__.py:10">
P2: Import path in docstring example is incorrect. The module is at `browser_use/swiftapi_integration/`, so the import should be `from browser_use.swiftapi_integration import ...` rather than `from swiftapi_integration import ...`.</violation>
</file>

Since this is your first cubic review, here's how it works:

cubic automatically reviews your code and comments on bugs and improvements
Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
Ask questions if you need clarification on any suggestion

_{Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2025-12-29T02:20:46Z

browser_use/swiftapi_integration/attestation.py

+            # Conservative: assume revoked if we can't check
+            return True
+
+    async def get_info(self) -> Dict[str, Any]:


P2: Unlike verify and check_revocation, this method lacks error handling for httpx exceptions. Consider wrapping in try/except for consistency and to provide meaningful AttestationError messages.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/attestation.py, line 189: <comment>Unlike `verify` and `check_revocation`, this method lacks error handling for httpx exceptions. Consider wrapping in try/except for consistency and to provide meaningful `AttestationError` messages.</comment> <file context> @@ -0,0 +1,315 @@ + # Conservative: assume revoked if we can't check + return True + + async def get_info(self) -> Dict[str, Any]: + """Get SwiftAPI authority info.""" + client = await self._get_client() </file context>

✅ Addressed in 26f307b

cubic-dev-ai · 2025-12-29T02:20:46Z

browser_use/swiftapi_integration/agent.py

+                    attest_all_actions=attest_all_actions,
+                )
+                # Copy registry from provided tools
+                swiftapi_tools.registry = provided_tools.registry


P2: Comment says 'Copy registry' but code shares the reference. If provided_tools.registry is modified elsewhere, it will affect swiftapi_tools. Consider using .model_copy() or creating a new registry instance if independent copies are intended.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/agent.py, line 102: <comment>Comment says 'Copy registry' but code shares the reference. If `provided_tools.registry` is modified elsewhere, it will affect `swiftapi_tools`. Consider using `.model_copy()` or creating a new registry instance if independent copies are intended.</comment> <file context> @@ -0,0 +1,160 @@ + attest_all_actions=attest_all_actions, + ) + # Copy registry from provided tools + swiftapi_tools.registry = provided_tools.registry + else: + # Create new SwiftAPI-enabled tools </file context>

✅ Addressed in 26f307b

cubic-dev-ai · 2025-12-29T02:20:46Z

browser_use/swiftapi_integration/tools.py

+            self._attestation_provider = None
+
+        self._attest_all_actions = attest_all_actions
+        self._attestation_cache: Dict[str, AttestationResult] = {}


P2: The _attestation_cache is initialized but never used. This suggests an incomplete caching implementation - attestation results are never cached, which could result in redundant attestation calls for repeated actions. Either implement the caching logic or remove this unused attribute.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/tools.py, line 167: <comment>The `_attestation_cache` is initialized but never used. This suggests an incomplete caching implementation - attestation results are never cached, which could result in redundant attestation calls for repeated actions. Either implement the caching logic or remove this unused attribute.</comment> <file context> @@ -0,0 +1,289 @@ + self._attestation_provider = None + + self._attest_all_actions = attest_all_actions + self._attestation_cache: Dict[str, AttestationResult] = {} + + def _requires_attestation(self, action_name: str) -> bool: </file context>

✅ Addressed in 26f307b

cubic-dev-ai · 2025-12-29T02:20:46Z

browser_use/swiftapi_integration/__init__.py

+before execution.
+
+Usage:
+    from swiftapi_integration import SwiftAPITools, SwiftAPIAgent


P2: Import path in docstring example is incorrect. The module is at browser_use/swiftapi_integration/, so the import should be from browser_use.swiftapi_integration import ... rather than from swiftapi_integration import ....

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/__init__.py, line 10: <comment>Import path in docstring example is incorrect. The module is at `browser_use/swiftapi_integration/`, so the import should be `from browser_use.swiftapi_integration import ...` rather than `from swiftapi_integration import ...`.</comment> <file context> @@ -0,0 +1,58 @@ +before execution. + +Usage: + from swiftapi_integration import SwiftAPITools, SwiftAPIAgent + + # Option 1: Use SwiftAPI-enabled Tools </file context>

✅ Addressed in 26f307b

cubic-dev-ai

3 issues found across 5 files (changes from recent commits).

Prompt for AI agents (all issues)


Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="browser_use/swiftapi_integration/attestation.py">

<violation number="1" location="browser_use/swiftapi_integration/attestation.py:142">
P2: Variable `action_fingerprint` is computed but never used. This appears to be dead code - either remove the computation or use the fingerprint (e.g., include it in the payload if intended).</violation>
</file>

<file name="browser_use/swiftapi_integration/tools.py">

<violation number="1" location="browser_use/swiftapi_integration/tools.py:246">
P2: Broad exception handling: Silently catching all exceptions when getting page URL could hide real issues. Consider catching specific exceptions or logging at debug level.</violation>

<violation number="2" location="browser_use/swiftapi_integration/tools.py:279">
P1: Potential attestation bypass: If no valid action is found in `model_dump`, `super().act()` is still called without attestation. For a fail-closed security module, consider validating that an action was found and attested, or raising an error when no action is detected.</violation>
</file>

_{Reply to cubic to teach it or ask questions. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai · 2025-12-29T02:37:26Z

browser_use/swiftapi_integration/attestation.py

+			'type': action_type,
+			'params': params,
+		}
+		action_fingerprint = hashlib.sha256(json.dumps(action_data, sort_keys=True).encode()).hexdigest()


P2: Variable action_fingerprint is computed but never used. This appears to be dead code - either remove the computation or use the fingerprint (e.g., include it in the payload if intended).

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/attestation.py, line 142: <comment>Variable `action_fingerprint` is computed but never used. This appears to be dead code - either remove the computation or use the fingerprint (e.g., include it in the payload if intended).</comment> <file context> @@ -24,297 +26,301 @@ + 'type': action_type, + 'params': params, + } + action_fingerprint = hashlib.sha256(json.dumps(action_data, sort_keys=True).encode()).hexdigest() + + # Build request payload </file context>

✅ Addressed in e28f00a

cubic-dev-ai · 2025-12-29T02:37:26Z

browser_use/swiftapi_integration/tools.py

+						if browser_session:
+							try:
+								page_url = await browser_session.get_current_page_url()
+							except Exception:


P2: Broad exception handling: Silently catching all exceptions when getting page URL could hide real issues. Consider catching specific exceptions or logging at debug level.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/tools.py, line 246: <comment>Broad exception handling: Silently catching all exceptions when getting page URL could hide real issues. Consider catching specific exceptions or logging at debug level.</comment> <file context> @@ -5,284 +5,287 @@ + if browser_session: + try: + page_url = await browser_session.get_current_page_url() + except Exception: + pass + </file context>

✅ Addressed in e28f00a

cubic-dev-ai · 2025-12-29T02:37:26Z

browser_use/swiftapi_integration/tools.py

+				break  # Only one action per ActionModel
+
+		# Call parent act() method if attestation passed
+		return await super().act(  # type: ignore[reportAttributeAccessIssue]


P1: Potential attestation bypass: If no valid action is found in model_dump, super().act() is still called without attestation. For a fail-closed security module, consider validating that an action was found and attested, or raising an error when no action is detected.

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At browser_use/swiftapi_integration/tools.py, line 279: <comment>Potential attestation bypass: If no valid action is found in `model_dump`, `super().act()` is still called without attestation. For a fail-closed security module, consider validating that an action was found and attested, or raising an error when no action is detected.</comment> <file context> @@ -5,284 +5,287 @@ + break # Only one action per ActionModel + + # Call parent act() method if attestation passed + return await super().act( # type: ignore[reportAttributeAccessIssue] + action=action, + browser_session=browser_session, </file context>

✅ Addressed in e28f00a

…alls

…heck

cubic-dev-ai bot reviewed Dec 29, 2025

View reviewed changes

theonlypal added 4 commits December 28, 2025 18:41

Add optional SwiftAPI attestation provider for action execution

b87b829

Fix review comments: error handling, import path, remove unused cache

ac5499b

Fix lint: pyupgrade, ruff, pyright type ignores for Generic super() c…

c40e389

…alls

Fix code review issues: remove unused var, add logging, fail-closed c…

e28f00a

…heck

theonlypal force-pushed the swiftapi-attestation branch from de56d3c to e28f00a Compare December 29, 2025 02:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add optional SwiftAPI attestation provider #3824

Add optional SwiftAPI attestation provider #3824

Uh oh!

theonlypal commented Dec 29, 2025 •

edited by cubic-dev-ai bot

Loading

Uh oh!

CLAassistant commented Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Add optional SwiftAPI attestation provider #3824

Are you sure you want to change the base?

Add optional SwiftAPI attestation provider #3824

Uh oh!

Conversation

theonlypal commented Dec 29, 2025 • edited by cubic-dev-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by cubic

Uh oh!

CLAassistant commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

theonlypal commented Dec 29, 2025 •

edited by cubic-dev-ai bot

Loading

CLAassistant commented Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading

cubic-dev-ai bot Dec 29, 2025 •

edited

Loading