[Tests] log when openssl doesn't support cipher #38
Merged
Conversation
calvinmetcalf
previously requested changes
Jan 3, 2018
calvinmetcalf
left a comment
calvinmetcalf
left a comment
Contributor
There was a problem hiding this comment.
looks good except for the standard nits, also we probably want to to put a try catch around the stuff on line 30 too. Thanks for doing this.
Contributor
Author
|
Seeing the fix for crypto-browserify i suppose that workaround is not right, then. |
Contributor
|
well the main one was just testing a single type of signature, so I just changed which one it was, for this one we have to test ALL of them so I think this is the right way. |
ljharb
changed the title
Member
|
I rebased this, and will do so again once I get CI restored, and then land it assuming it passes. |
ljharb
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #37.