commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/Krinkle/browserstack-runner/commit/826d2c7c9edbc442c1b3b0256f4115d7962bda15/hovercard" href="https://github.com/Krinkle/browserstack-runner/commit/826d2c7c9edbc442c1b3b0256f4115d7962bda15">826d2c7. Before that commit, the reason global "console" was globbered is that the `var console` part of the inner `var console = {}` assignment was hosted by the JavaScript engine. Thus the variable always existed in the local scope as type "undefined", and so the conditional check never saw the real console, and always created a custom one. Thus it always deleted the original console reference, as well as any other it contained. In commit 826d2c7, this was incorrectly fixed by assigning the unchecked expression referring to `console`, thus no longer having a fallback to `{}` in older browsers, because an unchecked reference like that throws an Uncaught ReferenceError. As a result, browserstack-runner was unable to run in IE 9 or older. Fixes browserstack#161. Fixes browserstack#164. Fixes browserstack#212.

Fix bad console assignment#241francisf merged 1 commit intobrowserstack:masterbrowserstack/browserstack-runner:masterfrom Krinkle:patch-1Krinkle/browserstack-runner:patch-1Copy head branch name to clipboard

Commits

Commits on Apr 11, 2021

Fix bad console assignment

Fix bad console assignment#241
francisf merged 1 commit intobrowserstack:masterfrom
Krinkle:patch-1