Less restrictive convenience hashing functions#35
Open
phil-k8r wants to merge 2 commits intobryant:masterfrom
phil-k8r:master
Open
Less restrictive convenience hashing functions#35phil-k8r wants to merge 2 commits intobryant:masterfrom phil-k8r:master
phil-k8r wants to merge 2 commits intobryant:masterfrom
phil-k8r:master
Conversation
Accept types that implement AsRef<u8> instead of &str as password and salt.
Make types of `password` and `salt` independent of each other and accept `Unsize`d types.
FauxFaux
added a commit
to FauxFaux/argon2min
that referenced
this pull request
Oct 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argon2::hash()accepts&[u8]as password and salt.argon2d_simple()andargon2i_simple()accept&stras password and saltand convert them to
&[u8].Instead of the conversion,
argon2d_simple()andargon2i_simple()could accepttypes that implement
AsRef<[u8]>or&[u8]directly.