Conversation
Member
Author
|
(Trying to see if CI will exercise the Dockerfile changes...) |
`easy_install` wasn't working; let's just add this dep.
Member
Author
|
I've locally tested that the Dockerfile still builds with |
pkwarren
reviewed
Jan 15, 2025
Member
pkwarren
left a comment
pkwarren
left a comment
There was a problem hiding this comment.
It looks like the Makefile still uses python3.8 too - should that be upgraded?
pkwarren
reviewed
Jan 15, 2025
pkwarren
approved these changes
Jan 15, 2025
stefanvanburen
added a commit
that referenced
this pull request
Jan 22, 2025
This fixes the python3.9 build by installing the pip requirements with python3.9 and ensuring python3.9-venv is installed. Follow up to #1225.
Merged
nicksnyder
pushed a commit
that referenced
this pull request
Jan 22, 2025
This fixes the python3.9 build by installing the pip requirements with python3.9 and ensuring python3.9-venv is installed. Follow up to #1225.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.