Merged
Conversation
Update to use env vars in setup-java as documented. Remove unnecessary gpg signing step as the gpg plugin does this. Update to build with Java 21 instead of 17.
pkwarren
commented
Dec 8, 2025
| SONATYPE_USER: ${{secrets.SONATYPE_USER}} | ||
| SONATYPE_PASSWORD: ${{secrets.SONATYPE_PASSWORD}} | ||
| GPG_KEY_NAME: ${{secrets.GPG_KEY_NAME}} | ||
| GPG_PASSPHRASE: ${{secrets.GPG_PASSPHRASE}} |
Member
Author
There was a problem hiding this comment.
These don't need to be set for the full job - just the release step.
| VERSION=${{ env.REF_NAME }} | ||
| echo "VERSION=${VERSION:1}" >> $GITHUB_ENV | ||
|
|
||
| - name: 'Configure GPG signing' |
Member
Author
There was a problem hiding this comment.
I'm pretty sure this is no longer necessary - if we set MAVEN_GPG_KEY and MAVEN_GPG_PASSPHRASE, the GPG signing should be automatic: https://maven.apache.org/plugins/maven-gpg-plugin/sign-mojo.html
| gpg-private-key: ${{ secrets.GPG_SECRET_KEY }} | ||
| gpg-passphrase: ${ env.GPG_PASSPHRASE } | ||
| server-username: SONATYPE_USERNAME | ||
| server-password: SONATYPE_PASSWORD |
Member
Author
There was a problem hiding this comment.
These are documented to be env vars, not the actual values: https://github.com/actions/setup-java/tree/f2beeb24e141e01a676f977032f5a29d81c9e27e?tab=readme-ov-file#maven-options
rodaine
approved these changes
Dec 8, 2025
rubensf
approved these changes
Dec 8, 2025
Member
rubensf
left a comment
rubensf
left a comment
There was a problem hiding this comment.
So we don't need secrets.GPG_SECRET_KEY anymore?
rubensf
approved these changes
Dec 8, 2025
rodaine
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to use env vars in setup-java as documented. Remove unnecessary gpg signing step as the gpg plugin does this. Update to build with Java 21 instead of 17.