Add a public release of the Cache Proxy#11756
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a public release path for the Enterprise cache proxy (“edge”) by wiring it into the release tooling and providing local build/run support.
Changes:
- Extend
release.pyto optionally build/push a newbuildbuddy-edge-enterpriseimage. - Add a local helper script to build/run the cache proxy Docker image.
- Add Bazel
go_image/container_imagetargets and a local config YAML for the cache proxy.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
release.py |
Adds --update_edge_image and pushes flame-public/buildbuddy-edge-enterprise from a Bazel image target. |
enterprise/tools/run_proxy_image.sh |
Local script to build the cache proxy image and run it with host networking and mounted config. |
enterprise/server/cmd/cache_proxy/BUILD |
Introduces Docker image build targets (go_image + container_image) for cache proxy. |
enterprise/config/cache-proxy.local.yaml |
Adds a local dev config for running the cache proxy against a local BuildBuddy server. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iain-macdonald
force-pushed
the
im/00155e5cde1
branch
2 times, most recently
from
677db22 to
def147a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
iain-macdonald
force-pushed
the
im/00155e5cde1
branch
from
def147a to
f717f9f
Compare
iain-macdonald
force-pushed
the
im/00155e5cde1
branch
from
f717f9f to
4d79f88
Compare
| @@ -0,0 +1,29 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
do we need this script (are there parallels for apps and other stuff?) Wonder if this should just be docs.
| skip_latest_tag = skip_update_latest_tag or arch_specific_executor_tag | ||
| push_image_for_project("flame-public/buildbuddy-executor-enterprise", executor_tag, '//enterprise/server/cmd/executor:executor_image', skip_latest_tag) | ||
| # Enterprise cache proxy (edge) | ||
| if 'buildbuddy-edge-enterprise' in images: |
There was a problem hiding this comment.
wdyt about keeping (cache-)proxy instead of introducing a new name here? I feel like it's a little confusing to have both and we don't use edge anywhere else.
There was a problem hiding this comment.
sounds good, updated
Related issues: https://github.com/buildbuddy-io/buildbuddy-internal/issues/6900