Normalize github url when fetching token#11803
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a regression from #11583 by ensuring GitHub repo URLs are normalized before looking up imported repositories and fetching GitHub App installation tokens, aligning runtime inputs with the normalized GitRepositories.repo_url values stored in the DB.
Changes:
- Normalize
repoURLviagitutil.ParseGitHubRepoURLbefore queryingGitRepositoriesfor the repo import record. - Pass a normalized repo URL through the convenience wrapper to ensure consistent behavior for callers.
- Add a unit test verifying
.git-suffixed repo URLs are accepted and resolved correctly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| enterprise/server/githubapp/githubapp.go | Normalize repo URL prior to DB lookup and propagate normalized URL in wrapper call. |
| enterprise/server/githubapp/githubapp_test.go | Add regression test ensuring repo URL normalization (e.g., handling .git suffix). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
siggisim
approved these changes
Apr 6, 2026
bduffany
approved these changes
Apr 7, 2026
maggie-lou
added a commit
that referenced
this pull request
Apr 7, 2026
Fixes a bug introduced in #11583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced in #11583