This repository was archived by the owner on Oct 31, 2024. It is now read-only.
Merged
Conversation
Collaborator
Author
|
The question is whether we should go ahead and run ProGuard on top of the minification that the shading does? There are a few classes that aren't stripped now that ProGuard can strip out, for example the XPath stuff that's mostly dead weight now. |
Contributor
|
If I read my local file sizes correctly, it shaves off another 9K (down from 447K), so I'm not really sure those space savings are really worth the additional risks associated with using yet another bytecode rewriting tool. |
Collaborator
Author
|
Let's not do it. File size isn't very important. |
It was used in the tests before we replaced it with the JUC JSON parser.
And don't include unused classes.
Mostly to say that we shade ANTLR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ANTLR is a bit of an unfortunate dependency since it's easy to get into version conflicts (we discovered this when we tried using
jmespath-javawith Druid for example).This uses
maven-shade-pluginto move all of the ANTLR runtime classes fromorg.antlrtoio.burt.jmespath.antlr.It also strips out the classes that we don't need (although we think that there are a few more that we could get rid of, the XPath implementation, for example).
It seems to be working, I got the
jmespath-jrubyto work without problems using the shaded artifact.