Minor performance improvements#44
Conversation
|
Are these changes necessary for something specific, or are you just changing things for the change's sake? We try not to make unnecessary changes unless we make functional changes to the code. I'm sure all of these changes are safe, but if it's not broken, you know. |
|
Not something specific, I was just quickly reading code and IntelliJ warnings. The last one reduces allocations so IMHO you should pick it too, all the more as tests are all green. Generally speaking, I'll probably do some profiling some day. For example, |
|
I can merge the string allocation changes, but I'd prefer to skip the cosmetic changes. You can either strip those out of this PR or I'll edit the commit before I merge. Profiling and PRs that improve performance would be greatly appreciated. |
|
The useless cast fix is not just cosmetic, casting has a cost. Are you OK with keeping this one too? |
* Use StringBuilder::append(CharSequence, int start, int end) instead of performing a substring and cause useless allocations. * Remove useless cast
Uh oh!
There was an error while loading. Please reload this page.