Use numerical constructor for Date so it is local; closes #2#7
Open
evanp wants to merge 1 commit intobyteclubfr:masterfrom
Open
Use numerical constructor for Date so it is local; closes #2#7evanp wants to merge 1 commit intobyteclubfr:masterfrom
evanp wants to merge 1 commit intobyteclubfr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
new Date(string)we donew Date(year, month, day), which will give a local value for the ymd. This matters if you're west of GMT, where local midnight is not the same date as GMT midnight.I also changed the test script so that it runs for two different timezones on either side of GMT, to make sure it works in all cases.