fix: Removes use of dirs in favor of etcetera#113
Merged
thomastaylor312 merged 1 commit intobytecodealliance:mainfrom Oct 11, 2024
Merged
fix: Removes use of dirs in favor of etcetera#113thomastaylor312 merged 1 commit intobytecodealliance:mainfrom
thomastaylor312 merged 1 commit intobytecodealliance:mainfrom
Conversation
The `dirs` crate doesn't actually respect XDG vars, so this swaps out to etcetera. This also has the side effect of removing a transitive dep that had an MPL licenses (which can cause headaches for CNCF and other projects). Also adds a global path for the file cache Fixes bytecodealliance#111 Fixes bytecodealliance#98 Signed-off-by: Taylor Thomas <taylor@cosmonic.com>
thomastaylor312
force-pushed
the
fix/config_path
branch
from
0da4725 to
a114e94
Compare
calvinrp
approved these changes
Oct 11, 2024
Collaborator
Author
|
Heads up that this will break anyone that has a config setup already, but since that is probably no more than 3-4 people in the world right now, I figured that is fine. Rather do it now before we start merging in the dep to everything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dirscrate doesn't actually respect XDG vars, so this swaps out to etcetera. This also has the side effect of removing a transitive dep that had an MPL licenses (which can cause headaches for CNCF and other projects).Also adds a global path for the file cache
Fixes #111
Fixes #98