feat(wasm-encoder): expose Ieee32 and Ieee64 constructors#2268
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Jul 30, 2025
Merged
feat(wasm-encoder): expose Ieee32 and Ieee64 constructors#2268alexcrichton merged 2 commits intobytecodealliance:mainfrom
alexcrichton merged 2 commits intobytecodealliance:mainfrom
Conversation
michaelficarra
requested review from
alexcrichton
and removed request for
a team
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
Thanks! Instead of making fields public could constructors be added? That'll provide ideally more flexibility in the future while also being a bit more idiomatic.
alexcrichton
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows consumers who already have their float bit pattern as a
u32/u64to not have to go through a cast tof32/f64just for theIeee32orIeee64constructors to cast it back. If being able to directly read/write the stored bit pattern is undesirable, I could implnewinstead. It doesn't look like #2157 added any tests for this struct, so I didn't add any either.