wasm-encoder: Use tuple-struct syntax for Ieee{32,64} fields#2269
Merged
fitzgen merged 1 commit intobytecodealliance:mainfrom Jul 30, 2025
Merged
wasm-encoder: Use tuple-struct syntax for Ieee{32,64} fields#2269fitzgen merged 1 commit intobytecodealliance:mainfrom
wasm-encoder: Use tuple-struct syntax for Ieee{32,64} fields#2269fitzgen merged 1 commit intobytecodealliance:mainfrom
Conversation
I didn't even know you could do named field syntax with the indices. In any case, the tuple-struct syntax is more idiomatic and vastly more common.
alexcrichton
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't even know you could do named field syntax with the indices. In any case, the tuple-struct syntax is more idiomatic and vastly more common.