Disallow non-type/instance aliases in component/instance types#2462
Open
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Open
Disallow non-type/instance aliases in component/instance types#2462alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
alexcrichton wants to merge 1 commit intobytecodealliance:mainfrom
Conversation
This fixes a bug in the validation of components where previously invalid `alias` items were allowed to be present in `instance` and `component` type definitions. The specification indicates that these should be disallowed and `wasmparser` erroneously allowed them. The impact of this change is expected to be nonexistent or negligible as this only applies to handwritten components. Components produced by `wit-component` do not use this feature so no previously produced component should be rejected. Additionally the impact of allowing these invalid `alias` annotations is also negligible as you couldn't actually do anything with the item anyway so it was just sort of dead bloat in a binary. cc WebAssembly/component-model#621
Member
Author
|
cc @lukewagner mind double-checking the logic here too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the validation of components where previously invalid
aliasitems were allowed to be present ininstanceandcomponenttype definitions. The specification indicates that these should be disallowed andwasmparsererroneously allowed them. The impact of this change is expected to be nonexistent or negligible as this only applies to handwritten components. Components produced bywit-componentdo not use this feature so no previously produced component should be rejected. Additionally the impact of allowing these invalidaliasannotations is also negligible as you couldn't actually do anything with the item anyway so it was just sort of dead bloat in a binary.cc WebAssembly/component-model#621