Implement printing of components in wasmprinter.#496
Merged
peterhuene merged 1 commit intoMar 7, 2022
Merged
Conversation
This commit implements printing of components in `wasmprinter`. The output text format is based on the current spec's textual representation. This does not alter the name section parsing implementation to update it for the component model; it is assumed that will be done when the `wat` implementation is completed.
14 tasks
alexcrichton
approved these changes
Mar 7, 2022
alexcrichton
left a comment
alexcrichton
left a comment
Member
There was a problem hiding this comment.
Seems reasonable to me! Most of wasmprinter, as I'm sure you've seen, is exactly highly tuned or anything like that, it's mostly whatever works for coming out of wasmparser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements printing of components in
wasmprinter.The output text format is based on the current spec's textual representation.
This does not alter the name section parsing implementation to update it for
the component model; it is assumed that will be done when the
watimplementation is completed.