Fix the .NET API for recent Wasmtime C API changes.#221
Merged
Conversation
This commit fixes the definition of `wasmtime_linker_define` to match what is currently expected upstream. As a result, items passed to `Linker.Define` must be associated with a store. The internal `IExternal` interface was updated to expose the store associated with the item for `LinkerDefine` to use. Also update the target framework to 7.0 (still `netstandard2.1` as well).
Member
Author
|
I'm going to see if I can expose the root cause for the flaky tarball downloads from GitHub that seems to only impact the Windows CI machines given it's still happening. |
Member
Author
Sigh. The inner exception seems to be completely eaten by the task and not logged in anyway at even a diagnostic logging level. |
Member
Author
|
I'm going to merge this for now and we'll figure out the transient download issues on the Windows CI later (it'll require implementing our own |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the definition of
wasmtime_linker_defineto match what is currently expected upstream.As a result, items passed to
Linker.Definemust be associated with a store.The internal
IExternalinterface was updated to expose the store associated with the item forLinkerDefineto use.Also update the target framework to 7.0 (still
netstandard2.1as well).