Instance Get All Exports#290
Merged
peterhuene merged 5 commits intoJan 2, 2024
Merged
Conversation
- Removed `wasmtime_instancetype_delete` (doesn't appear to be part of the c-api any more)
Contributor
Author
|
Linux CI seems to be failing due to a file not copying into the test environment properly. I'm not sure why :/ |
kpreisser
reviewed
Dec 24, 2023
Co-authored-by: Konstantin Preißer <kpreisser@users.noreply.github.com>
peterhuene
approved these changes
Jan 2, 2024
Member
peterhuene
left a comment
peterhuene
left a comment
There was a problem hiding this comment.
Just some minor nit comments, otherwise looks good!
Co-authored-by: Peter Huene <peter@huene.dev>
Contributor
Author
|
I've merged all those review suggestions and have removed the unnecessary doc comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added methods to fetch all exports from an Instance, using
wasmtime_instance_export_nthto enumerate exports.Also removed
wasmtime_instancetype_delete, since it doesn't appear to be part of the c-api any more.