Skip to content

Fix CI.#305

Merged
peterhuene merged 3 commits into
bytecodealliance:mainfrom
peterhuene:update-ci
Apr 16, 2024
Merged

Fix CI.#305
peterhuene merged 3 commits into
bytecodealliance:mainfrom
peterhuene:update-ci

Conversation

@peterhuene
Copy link
Copy Markdown
Member

This commit:

  • Updates target framework to net8.0.
  • Fixes the externref API to match recent changes in upstream Wasmtime.
  • Remove WASI "snapshot 0" from the tests (so old!).

This commit:

* Updates target framework to `net8.0`.
* Fixes the `externref` API to match recent changes in upstream Wasmtime.
* Remove WASI "snapshot 0" from the tests (so old!).
@peterhuene
Copy link
Copy Markdown
Member Author

"The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\tmpbr2aoc.tmp' because it is being used by another process."

Oh, Windows, never change.

Comment thread benchmarks/simple/simple.csproj
@kpreisser
Copy link
Copy Markdown
Contributor

"The process cannot access the file 'C:\Users\runneradmin\AppData\Local\Temp\tmpbr2aoc.tmp' because it is being used by another process."

FYI, on Windows it depends on which FileShare is specified when opening the file. When using File.ReadAllText(), it seems .NET specifies FileShare.Read, meaning opening the file fails when other code has opened the file for writing.
It should work if you manually specify FileShare.ReadWrite, which allows others to open the file for reading and writing, as long as they specify a Read file share (allowing us to open the file for reading).

@peterhuene peterhuene merged commit b2b0480 into bytecodealliance:main Apr 16, 2024
@peterhuene peterhuene deleted the update-ci branch April 16, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants