Skip to content

Bind wasmtime_trap_exit_status#35

Merged
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:exit-trap
Jun 23, 2020
Merged

Bind wasmtime_trap_exit_status#35
alexcrichton merged 1 commit into
bytecodealliance:mainfrom
alexcrichton:exit-trap

Conversation

@alexcrichton
Copy link
Copy Markdown
Member

  • Add an ExitTrap subclass of Trap
  • Return an appropriate trap from Trap.__from_ptr__
  • Attach the exit code via a code field

Closes #30

* Add an `ExitTrap` subclass of `Trap`
* Return an appropriate trap from `Trap.__from_ptr__`
* Attach the exit code via a `code` field

Closes bytecodealliance#30
@alexcrichton alexcrichton merged commit 54b491d into bytecodealliance:main Jun 23, 2020
@alexcrichton alexcrichton deleted the exit-trap branch June 23, 2020 18:40
@whitequark
Copy link
Copy Markdown
Contributor

Thank you! Can I get a release? The lack of exit trap handling is currently making all of my wasmtime-py based applications crash on exit, so not very good.

@alexcrichton
Copy link
Copy Markdown
Member Author

Sure thing! I updated to 0.18.1

@whitequark
Copy link
Copy Markdown
Contributor

Thanks, works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handling the exit trap

2 participants