Missing define/undef of 'own' symbol for wasmtime.h

[rene-fonseca]

#define own
and
#undef own

are missing for new wasmtime.h.

Both wasi.h and wasm.h define own properly.

[rene-fonseca]

Also, there is an extra , - that breaks build.

https://github.com/bytecodealliance/wasmtime/blob/master/crates/c-api/include/wasmtime.h#L58

bool wasmtime_wat2wasm(
wasm_engine_t *engine,
const wasm_byte_vec_t *wat,
own wasm_byte_vec_t *ret,
own wasm_byte_vec_t *error_message, // <<< REMOVE ,
);

[rene-fonseca]

@alexcrichton FYI

[rene-fonseca]

And then I like:
#include <wasm.h>
changed to:
#include "wasm.h"

This will allow headers to work regardless of the include search path. wasi.h already uses #include "wasm.h" as desired.

See note in #1211

[rene-fonseca]

FYI This was tested with clang.

[rene-fonseca]

Maybe error_message should use wasm_message_t instead of wasm_byte_vec_t for consistency.

[rene-fonseca]

API confirmed to work with https://github.com/bytecodealliance/wasmtime/blob/master/tests/wat/rs2wasm-add-func.wat .

[alexcrichton]

I believe this was fixed in #1286, and we're not verifying the header file is usable on CI!

[rene-fonseca]

Yes, fixed now.

[rene-fonseca]

Oh I still like the #include <wasm.h> changed though - see above.

[alexcrichton]

Can you open a separate issue? It's hard to dig through the comments of an unrelated issue to see what needs fixing.

[rene-fonseca]

Opened #1313