Skip to content

wasmtime::CoreDump::_serialize shouldn't need a generic T in its store #7083

@fitzgen

Description

@fitzgen

Follow up to #7078 (comment)

It is there because the method calls public APIs that require a store with a T but none of them actually use the T. For every pub fn foo<T> that is called, we could create a pub(crate) fn _foo without the T and then call those methods from _serialize and ultimately remove the T from _serialize.

This would make it so that calling wasmtime::CoreDump::serialize isn't monomorphized for every T in a store passed to it, which can help compile times when there is more than one T used in the program.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions