Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 34 additions & 3 deletions crates/test-macros/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,15 @@
//! }
//! ```
//!
//! To use just one specific compiler strategy:
//!
//! ```rust
//! #[wasmtime_test(strategies(only(Winch)))]
//! fn my_test(config: &mut Config) -> Result<()> {
//! Ok(())
//! }
//! ```
//!
//! To explicitly indicate that a wasm features is needed
//! ```
//! #[wasmtime_test(wasm_features(gc))]
Expand Down Expand Up @@ -54,9 +63,27 @@ impl TestConfig {
if meta.path.is_ident("Winch") {
self.strategies.retain(|s| *s != Compiler::Winch);
Ok(())
} else if meta.path.is_ident("Cranelift") {
} else if meta.path.is_ident("CraneliftNative") {
self.strategies.retain(|s| *s != Compiler::CraneliftNative);
Ok(())
} else if meta.path.is_ident("CraneliftPulley") {
self.strategies.retain(|s| *s != Compiler::CraneliftPulley);
Ok(())
} else {
Err(meta.error("Unknown strategy"))
}
})
} else if meta.path.is_ident("only") {
meta.parse_nested_meta(|meta| {
if meta.path.is_ident("Winch") {
self.strategies.retain(|s| *s == Compiler::Winch);
Ok(())
} else if meta.path.is_ident("CraneliftNative") {
self.strategies.retain(|s| *s == Compiler::CraneliftNative);
Ok(())
} else if meta.path.is_ident("CraneliftPulley") {
self.strategies.retain(|s| *s == Compiler::CraneliftPulley);
Ok(())
} else {
Err(meta.error("Unknown strategy"))
}
Expand Down Expand Up @@ -97,7 +124,11 @@ impl TestConfig {
impl Default for TestConfig {
fn default() -> Self {
Self {
strategies: vec![Compiler::CraneliftNative, Compiler::Winch],
strategies: vec![
Compiler::CraneliftNative,
Compiler::Winch,
Compiler::CraneliftPulley,
],
flags: Default::default(),
test_attribute: None,
}
Expand Down Expand Up @@ -193,7 +224,7 @@ fn expand(test_config: &TestConfig, func: Fn) -> Result<TokenStream> {
let mut tests = if test_config.strategies == [Compiler::Winch] {
vec![quote! {
// This prevents dead code warning when the macro is invoked as:
// #[wasmtime_test(strategies(not(Cranelift))]
// #[wasmtime_test(strategies(only(Winch))]
// Given that Winch only fully supports x86_64.
#[allow(dead_code)]
#func
Expand Down
2 changes: 1 addition & 1 deletion tests/all/fuel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ fn get_fuel_clamps_at_zero(config: &mut Config) -> Result<()> {
Ok(())
}

#[wasmtime_test(strategies(not(Cranelift)))]
#[wasmtime_test(strategies(only(Winch)))]
#[cfg_attr(miri, ignore)]
fn ensure_stack_alignment(config: &mut Config) -> Result<()> {
config.consume_fuel(true);
Expand Down
29 changes: 18 additions & 11 deletions tests/all/func.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2085,18 +2085,25 @@ fn typed_v128_imports(config: &mut Config) -> anyhow::Result<()> {
#[cfg_attr(miri, ignore)]
fn wrap_and_typed_i31ref(config: &mut Config) -> Result<()> {
let engine = Engine::new(&config)?;
let mut store = Store::new(&engine, ());
let mut store = Store::<AtomicUsize>::new(&engine, AtomicUsize::new(0));

static HITS: AtomicUsize = AtomicUsize::new(0);
let mut linker = Linker::new(&engine);
linker.func_wrap("env", "i31ref", |x: Option<I31>| -> Option<I31> {
assert_eq!(HITS.fetch_add(1, Ordering::SeqCst), 0);
x
})?;
linker.func_wrap("env", "ref-i31", |x: I31| -> I31 {
assert_eq!(HITS.fetch_add(1, Ordering::SeqCst), 1);
x
})?;
linker.func_wrap(
"env",
"i31ref",
|caller: Caller<'_, AtomicUsize>, x: Option<I31>| -> Option<I31> {
assert_eq!(caller.data().fetch_add(1, Ordering::SeqCst), 0);
x
},
)?;
linker.func_wrap(
"env",
"ref-i31",
|caller: Caller<'_, AtomicUsize>, x: I31| -> I31 {
assert_eq!(caller.data().fetch_add(1, Ordering::SeqCst), 1);
x
},
)?;

let module = Module::new(
&engine,
Expand Down Expand Up @@ -2128,7 +2135,7 @@ fn wrap_and_typed_i31ref(config: &mut Config) -> Result<()> {
let x = ref_i31.call(&mut store, I31::wrapping_u32(0x1234))?;
assert_eq!(x, I31::wrapping_u32(0x1234));

assert_eq!(HITS.load(Ordering::SeqCst), 2);
assert_eq!(store.data().load(Ordering::SeqCst), 2);
Ok(())
}

Expand Down
6 changes: 3 additions & 3 deletions tests/all/winch_engine_features.rs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
use wasmtime::*;
use wasmtime_test_macros::wasmtime_test;

#[wasmtime_test(strategies(not(Cranelift)))]
#[wasmtime_test(strategies(only(Winch)))]
#[cfg_attr(miri, ignore)]
fn ensure_compatibility_between_winch_and_table_lazy_init(config: &mut Config) -> Result<()> {
config.table_lazy_init(false);
Expand All @@ -21,7 +21,7 @@ fn ensure_compatibility_between_winch_and_table_lazy_init(config: &mut Config) -
Ok(())
}

#[wasmtime_test(strategies(not(Cranelift)))]
#[wasmtime_test(strategies(only(Winch)))]
#[cfg_attr(miri, ignore)]
fn ensure_compatibility_between_winch_and_signals_based_traps(config: &mut Config) -> Result<()> {
config.signals_based_traps(false);
Expand All @@ -43,7 +43,7 @@ fn ensure_compatibility_between_winch_and_signals_based_traps(config: &mut Confi
Ok(())
}

#[wasmtime_test(strategies(not(Cranelift)))]
#[wasmtime_test(strategies(only(Winch)))]
#[cfg_attr(miri, ignore)]
fn ensure_compatibility_between_winch_and_generate_native_debuginfo(
config: &mut Config,
Expand Down