wasmtime-wit-bindgen: use core instead of std in all emitted code#10105
Merged
Conversation
alexcrichton
approved these changes
Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve compatibility with #![no_std] builds by substituting all uses of
std::forcore::in wasmtime-wit-bindgen output.The one use of the
stdcargo feature in this crate was to gate emittingimpl std::error::Error for ..., now that Error is in core we can unconditionally emit animpl core::error::Error for ..., and eliminate thestdcargo feature in thewasmtime-wit-bindgenandwasmtime-component-macrocrates.