asm: avoid propagating arbitrary#10217
Merged
Merged
Conversation
This is something that @alexcrichton already fixed over in the assembler crate--no need to implement `Arbitrary` unnecessarily. It's unclear how this stayed in here in `cranelift-codegen` but this change removes it.
cfallin
approved these changes
Feb 11, 2025
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Feb 25, 2025
This is something that @alexcrichton already fixed over in the assembler crate--no need to implement `Arbitrary` unnecessarily. It's unclear how this stayed in here in `cranelift-codegen` but this change removes it.
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Feb 25, 2025
This is something that @alexcrichton already fixed over in the assembler crate--no need to implement `Arbitrary` unnecessarily. It's unclear how this stayed in here in `cranelift-codegen` but this change removes it.
cfallin
pushed a commit
that referenced
this pull request
Feb 25, 2025
* asm: avoid propagating `arbitrary` (#10217) This is something that @alexcrichton already fixed over in the assembler crate--no need to implement `Arbitrary` unnecessarily. It's unclear how this stayed in here in `cranelift-codegen` but this change removes it. * Update release notes --------- Co-authored-by: Andrew Brown <andrew.brown@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something that @alexcrichton already fixed over in the assembler crate--no need to implement
Arbitraryunnecessarily. It's unclear how this stayed in here incranelift-codegenbut this change removes it.