x64: fix scalar_to_vector with i16x8 types#10949
Merged
Merged
Conversation
This also includes a compile test; the disassembly makes things more clear.
github-actions
Bot
added
cranelift
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
* Add a test for reproducing bytecodealliance#10906 This also includes a compile test; the disassembly makes things more clear. * Fix bytecodealliance#10906 by zeroing the XMM register prior to use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced in #9045 where the XMM register used as an
i16x8destination forscalar_to_vectoris not properly zeroed prior to moving thei16there. This means that uninitialized bits from previous instructions are readable in the top lanes of the destination. The fix for this miscompilation is to zero the XMM register prior to moving thei16to the XMM.Fixes #10906.