x64: Migrate movddup to the new assembler#10958
Merged
Merged
Conversation
Enables removing the `XmmUnaryRmRUnaligned` instruction variant. Additionally this exposed a shortcoming where Cranelift didn't have access for testing for SSE3 in ISLE (not to be confused with SSSE3). Additionally `movddup` was incorrectly classified as SSSE3 so this commit fills out some infrastructure to use SSE3 instead of SSSE3. There are more instructions as well that are mis-classified under SSSE3 which I'll address in a follow-up.
Member
Author
|
On the topic of SSE3 testing lacking in Cranelift and instructions mis-classified as SSSE3 instead of SSE3 AFAIK it's benign and otherwise dates back to #6025 where I assume I misread something and got the classification wrong. I think that |
github-actions
Bot
added
cranelift
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "cranelift:meta", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
approved these changes
Jun 6, 2025
bongjunj
pushed a commit
to prosyslab/wasmtime
that referenced
this pull request
Oct 20, 2025
Enables removing the `XmmUnaryRmRUnaligned` instruction variant. Additionally this exposed a shortcoming where Cranelift didn't have access for testing for SSE3 in ISLE (not to be confused with SSSE3). Additionally `movddup` was incorrectly classified as SSSE3 so this commit fills out some infrastructure to use SSE3 instead of SSSE3. There are more instructions as well that are mis-classified under SSSE3 which I'll address in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables removing the
XmmUnaryRmRUnalignedinstruction variant. Additionally this exposed a shortcoming where Cranelift didn't have access for testing for SSE3 in ISLE (not to be confused with SSSE3). Additionallymovddupwas incorrectly classified as SSSE3 so this commit fills out some infrastructure to use SSE3 instead of SSSE3. There are more instructions as well that are mis-classified under SSSE3 which I'll address in a follow-up.